fix(core): fix bug loading of `.redocly.lint-ignore.yaml` in browser environments #2489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

kanoru3101 wants to merge 13 commits into main from fix/ignore-file-for-browser

+121 −71

Contributor

kanoru3101 commented Jan 7, 2026 •

edited

Loading

What/Why/How?

Fixed loading of .redocly.lint-ignore.yaml in browser environments (Reunite).

Reference

Testing

Screenshots (optional)

Check yourself

Code changed? - Tested with Redoc/Realm/Reunite (internal)
All new/updated code is covered by tests
New package installed? - Tested in different environments (browser/node)
Documentation update considered

Security

The security impact of the change has been considered
Code follows company security practices and guidelines


          fix: update lint-ignore logic

53e4d61

changeset-bot bot commented Jan 7, 2026 •

edited

Loading

🦋 Changeset detected

Latest commit: 4a53e67

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages

Name	Type
@redocly/openapi-core	Patch
@redocly/cli	Patch
@redocly/respect-core	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

kanoru3101 self-assigned this

Contributor

github-actions bot commented Jan 7, 2026 •

edited

Loading

Coverage Report

Status	Category	Percentage	Covered / Total
🔵	Lines	78.6% (🎯 78%)	6204 / 7893
🔵	Statements	78.02% (🎯 78%)	6410 / 8215
🔵	Functions	81.98% (🎯 81%)	1265 / 1543
🔵	Branches	70.37% (🎯 70%)	4255 / 6046

File Coverage

File	Stmts	Branches	Functions	Lines	Uncovered Lines
Changed Files
packages/core/src/config/config.ts	63.53%	65.67%	76.92%	63.97%	169-193, 219, 223, 227-245, 277, 295-315, 394-424
packages/core/src/config/load.ts	90.19%	72.88%	100%	91.83%	21, 52, 90, 114, 159

Generated in workflow #8297 for commit 4a53e67 by the Vitest Coverage Report Action

Contributor

github-actions bot commented Jan 7, 2026 •

edited

Loading

CLI Version	Mean Time ± Std Dev (s)	Relative Performance (Lower is Faster)
cli-latest	3.411s ± 0.025s	▓ 1.00x
cli-next	3.408s ± 0.015s	▓ 1.00x (Fastest)


          fix: update tests

323e239

kanoru3101 added the snapshot label

Contributor

github-actions bot commented Jan 7, 2026

📦 A new experimental 🧪 version v0.0.0-snapshot.1767804621 of Redocly CLI has been published for testing.

Install with NPM:

npm install @redocly/[email protected]
# or
npm install @redocly/[email protected]
# or
npm install @redocly/[email protected]

⚠️ Note: This is a development build and may contain unstable features.


          fix: add logs

f0491ec

kanoru3101 added snapshot and removed snapshot labels

Contributor

github-actions bot commented Jan 7, 2026

📦 A new experimental 🧪 version v0.0.0-snapshot.1767807792 of Redocly CLI has been published for testing.

Install with NPM:

npm install @redocly/[email protected]
# or
npm install @redocly/[email protected]
# or
npm install @redocly/[email protected]

⚠️ Note: This is a development build and may contain unstable features.


          fix: refactoring

04aff2e

kanoru3101 added snapshot and removed snapshot labels

Contributor

github-actions bot commented Jan 8, 2026

📦 A new experimental 🧪 version v0.0.0-snapshot.1767866050 of Redocly CLI has been published for testing.

Install with NPM:

npm install @redocly/[email protected]
# or
npm install @redocly/[email protected]
# or
npm install @redocly/[email protected]

⚠️ Note: This is a development build and may contain unstable features.

kanoru3101 added 2 commits

January 8, 2026 12:07


          fix: refactoring

80c55f0


          fix: revert changes

b12cd36

kanoru3101 added snapshot and removed snapshot labels

Contributor

github-actions bot commented Jan 8, 2026

📦 A new experimental 🧪 version v0.0.0-snapshot.1767870619 of Redocly CLI has been published for testing.

Install with NPM:

npm install @redocly/[email protected]
# or
npm install @redocly/[email protected]
# or
npm install @redocly/[email protected]

⚠️ Note: This is a development build and may contain unstable features.

kanoru3101 added snapshot and removed snapshot labels

Contributor

github-actions bot commented Jan 8, 2026

📦 A new experimental 🧪 version v0.0.0-snapshot.1767871282 of Redocly CLI has been published for testing.

Install with NPM:

npm install @redocly/[email protected]
# or
npm install @redocly/[email protected]
# or
npm install @redocly/[email protected]

⚠️ Note: This is a development build and may contain unstable features.


          fix: update tests

25d06f0

kanoru3101 added snapshot and removed snapshot labels

Contributor

github-actions bot commented Jan 8, 2026

📦 A new experimental 🧪 version v0.0.0-snapshot.1767882364 of Redocly CLI has been published for testing.

Install with NPM:

npm install @redocly/[email protected]
# or
npm install @redocly/[email protected]
# or
npm install @redocly/[email protected]

⚠️ Note: This is a development build and may contain unstable features.

kanoru3101 changed the title ~~fix: update lint-ignore logic~~ fix(core): update lint-ignore logic for reunite

kanoru3101 changed the title ~~fix(core): update lint-ignore logic for reunite~~ fix(core): update loading of .redocly.lint-ignore.yaml in browser environments


          fix: add logs

dd80539

kanoru3101 added snapshot and removed snapshot labels

Contributor

github-actions bot commented Jan 8, 2026

📦 A new experimental 🧪 version v0.0.0-snapshot.1767884148 of Redocly CLI has been published for testing.

Install with NPM:

npm install @redocly/[email protected]
# or
npm install @redocly/[email protected]
# or
npm install @redocly/[email protected]

⚠️ Note: This is a development build and may contain unstable features.


          fix(core): remove logs

fb47186

kanoru3101 changed the title ~~fix(core): update loading of .redocly.lint-ignore.yaml in browser environments~~ fix(core): fix bug loading of .redocly.lint-ignore.yaml in browser environments

kanoru3101 added 2 commits

January 8, 2026 19:32


          fix(core): remove comments

0f336e4


          fix(core): refactoring

a12049c

kanoru3101 added snapshot and removed snapshot labels

Contributor

github-actions bot commented Jan 8, 2026

📦 A new experimental 🧪 version v0.0.0-snapshot.1767894238 of Redocly CLI has been published for testing.

Install with NPM:

npm install @redocly/[email protected]
# or
npm install @redocly/[email protected]
# or
npm install @redocly/[email protected]

⚠️ Note: This is a development build and may contain unstable features.


          Merge remote-tracking branch 'origin/main' into fix/ignore-file-for-b…

2d024cc

…rowser

kanoru3101 added snapshot and removed snapshot labels

Contributor

github-actions bot commented Jan 8, 2026

📦 A new experimental 🧪 version v0.0.0-snapshot.1767895703 of Redocly CLI has been published for testing.

Install with NPM:

npm install @redocly/[email protected]
# or
npm install @redocly/[email protected]
# or
npm install @redocly/[email protected]

⚠️ Note: This is a development build and may contain unstable features.


          Merge remote-tracking branch 'origin/main' into fix/ignore-file-for-b…

4a53e67

…rowser

kanoru3101 marked this pull request as ready for review

January 8, 2026 18:59

kanoru3101 requested review from a team as code owners

January 8, 2026 18:59

tatomyr requested changes

View reviewed changes

Collaborator

tatomyr left a comment

Left a couple of comments. Will take another round soon.

packages/core/src/config/__tests__/fixtures/ignore-file/redocly.yaml

    
            @@ -0,0 +1,2 @@
          
              rules:

                operation-operationId: error

Collaborator

tatomyr Jan 12, 2026

Could you add yet another rule (but don't ignore it) so we can be sure it ignores only what's supposed to be ignored?

packages/core/src/config/load.ts

    
              import type { RawUniversalConfig } from './types.js';

              function isUrl(ref: string): boolean {

Collaborator

tatomyr Jan 12, 2026

I believe we have something similar to this (isAbsolutePath? Maybe it needs to be adjusted.)
Could you check the codebase?

packages/core/src/config/load.ts

Comment on lines +57 to +63

    
                for (const fileName of Object.keys(ignore)) {

                  const resolvedFileName = isUrl(fileName) ? fileName : resolvePath(configDir, fileName);

                  ignore[resolvedFileName] = ignore[fileName];

                  for (const ruleId of Object.keys(ignore[fileName])) {

                    ignore[fileName][ruleId] = new Set(ignore[fileName][ruleId]);

Collaborator

tatomyr Jan 12, 2026

Why do we need this mapper? Cannot we just use whatever we've resolved?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels